ImagingDataCommons / CloudSegmentator

Medical imaging segmentation workflows for FireCloud (Terra) and Seven Bridges Cancer Genomics Cloud
Apache License 2.0
3 stars 2 forks source link

Notebooks2 #35

Closed vkt1414 closed 8 months ago

vkt1414 commented 8 months ago

This PR address #5

review-notebook-app[bot] commented 8 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

fedorov commented 8 months ago

@vkt1414 is it necessary to keep the output cells in the notebooks?

vkt1414 commented 8 months ago

@vkt1414 is it necessary to keep the output cells in the notebooks?

Not necessary..would you like me to clear the output for all notebooks?

fedorov commented 8 months ago

Here are suggested updates:

Once these are fixed, let's just merge this, and I will review by experimenting with the notebooks.

vkt1414 commented 8 months ago
  • remove output (to make it easier to open the notebook in GitHub)

Done

  • do not use aws_url in any intermediate queries to reduce complexity and cost
  • start using CONCAT(aws_bucket,'/',crdc_series_uuid) for forming the series folder path

Will be addressing these from sqlqueryfix branch

Done

Once these are fixed, let's just merge this, and I will review by experimenting with the notebooks.

Please go ahead