Closed vkt1414 closed 8 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@vkt1414 is it necessary to keep the output cells in the notebooks?
@vkt1414 is it necessary to keep the output cells in the notebooks?
Not necessary..would you like me to clear the output for all notebooks?
Here are suggested updates:
aws_url
in any intermediate queries to reduce complexity and costCONCAT(aws_bucket,'/',crdc_series_uuid)
for forming the series folder pathOnce these are fixed, let's just merge this, and I will review by experimenting with the notebooks.
- remove output (to make it easier to open the notebook in GitHub)
Done
- do not use
aws_url
in any intermediate queries to reduce complexity and cost- start using
CONCAT(aws_bucket,'/',crdc_series_uuid)
for forming the series folder path
Will be addressing these from sqlqueryfix branch
- instead of pasting the binary of the images, let's keep all images in a dedicated folder, and insert them by references (you can see an example in https://github.com/ImagingDataCommons/IDC-Tutorials/blob/master/notebooks/getting_started/part1_prerequisites.ipynb - but don't use dropbox links like I did for that notebook - let's put the links into "images" folder, for example)
Done
Once these are fixed, let's just merge this, and I will review by experimenting with the notebooks.
Please go ahead
This PR address #5