search

ImagingDataCommons / CloudSegmentator

Medical imaging segmentation workflows for FireCloud (Terra) and Seven Bridges Cancer Genomics Cloud
Apache License 2.0
3 stars 2 forks source link

use code meanings from dicom standard #36

Closed vkt1414 closed 8 months ago

vkt1414 commented 8 months ago

Upon suggestion to use code meanings from DICOM standard instead of IBSI, I looked up the code meanings at https://dicom.nema.org/medical/dicom/current/output/pdf/part16.pdf#CID%207476%20Gray%20Level%20Size%20Zone%20Based%20Feature

I found that code meanings were more 'complete' in the DICOM standard. While I could find code meanings for all shape featues, first-order features in the DICOM standard contained only codes when pyradiomics features are used with arbitrary units i.e Intensity Histogram features. More on the arbitrary vs calibrated units can be found in #34. This makes me wonder if my understanding of arbitrary vs calibrated is correct or not.

fedorov commented 8 months ago

I looked up the code meanings at https://dicom.nema.org/medical/dicom/current/output/pdf/part16.pdf#CID%207476%20Gray%20Level%20Size%20Zone%20Based%20Feature

To avoid miscommunication, it is best to reference specific locations in the chtml version of the standard.

I think this is ok to merge. I will create a separate issue to initialize units based on the input modality.