ImagingDataCommons / CloudSegmentator

Medical imaging segmentation workflows for FireCloud (Terra) and Seven Bridges Cancer Genomics Cloud
Apache License 2.0
3 stars 2 forks source link

sr does not need dicom files in order,fix invisible char in radiomics… #43

Closed vkt1414 closed 8 months ago

vkt1414 commented 8 months ago

This PR addresses #6.

I ran the radiomics notebook with and with out sorting and checked the quant values b/w with the query below after extracting measurement groups and quant values. As expected there was no difference b/w the two. Unsure if we need to check anything else.

CurrentRequestedProcedureEvidenceSequence.ReferencedSeriesSequence.ReferencedSOPSequence.ReferencedSOPInstanceUID were not in the same order and that's expected I guess.

with w_sorting as
(select
sourceSegmentedSeriesUID,
trackingIdentifier,
Quantity.CodeMeaning,
Value v1
from
`idc-external-025.test_sort.quant_w_sorting` 
),
wo_sorting as 
(
select
sourceSegmentedSeriesUID,
trackingIdentifier,
Quantity.CodeMeaning,
Value v2
from
`idc-external-025.test_sort.quant_wo_sorting`
)

Select * from w_sorting
join wo_sorting using (sourceSegmentedSeriesUID,trackingIdentifier,CodeMeaning)
where  v1!=v2

I also found some wierd character pop up in SRs, so updated the csv file to remove them.

review-notebook-app[bot] commented 8 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB