search

ImagingDataCommons / CloudSegmentator

Medical imaging segmentation workflows for FireCloud (Terra) and Seven Bridges Cancer Genomics Cloud
Apache License 2.0
3 stars 2 forks source link

initialize SegmentLabel from SegmentDescription #50

Closed fedorov closed 9 months ago

fedorov commented 9 months ago

Without SegmentLabel in JSON, dcmqi currently uses the heuristic to populate it from SegmentedPropertyTypeCodeSequence>CodeMeaning, which is suboptimal, since it does not take into account laterality. At the same time, SegmentLabel is used both by OHIF and Slicer (see https://github.com/QIICR/QuantitativeReporting/blob/master/DICOMPlugins/DICOMSegmentationPlugin.py#L202) to initialize segment names shown to the user. Related to this PR that will revisit the heuristic used by dcmqi, and use SegmentDescription if SegmentLabel is not available before defaulting to segmented property type code meaning: https://github.com/QIICR/dcmqi/pull/488

vkt1414 commented 9 months ago

I loaded a sample seg into slicer and it looks good. thanks!