ImagingDataCommons / ETL

(CORE REPO)
Apache License 2.0
0 stars 1 forks source link

Make column names capitalization consistent #14

Open fedorov opened 3 years ago

fedorov commented 3 years ago

As much as possible, it would be helpful if the names of the columns in the auxiliary table were capitalized consistently.

Currently, all DICOM attributes in dicom_metadata follow CamelCase convention, while most of the columns in the aux table are all lower caps with underscore separator.

Since for most users the primary table will be dicom_all, which is a mix of DICOM and non-DICOM items, it would be very convenient to be able to easily differentiate between those two groups.

The following are exceptions to the capitalization convention in the aux table are the following attributes:

Collection-level tables also use CameCase, but since neither of those attributes is coming from DICOM, and they are not included in dicom_all, this is less consequential, although maybe we should consider making it lower case to be consistent with the aux table.