search

ImagingDataCommons / IDC-Tutorials

Self-guided notebook tutorials to help get started with using IDC
BSD 3-Clause "New" or "Revised" License
28 stars 14 forks source link

Created using Colaboratory #23

Closed bcli4d closed 1 year ago

bcli4d commented 1 year ago

Mention AWS as cloud provider in addition to GCP

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

fedorov commented 1 year ago

I think what needs to be changed is part 3 of the tutorial. There are no prerequisite to downloading data from AWS, the only adjustment is the download tool - s5cmd instead of gsutil, and which column is used to get the URLs. Mentioning AWS in part 1 is somewhat out of place, because nothing is done wrt AWS in part 1.

bcli4d commented 1 year ago

OK. I'll let you do these notebooks.

On Mon, May 1, 2023 at 6:40 PM Andrey Fedorov @.***> wrote:

I think what needs to be changed is part 3 of the tutorial. There are no prerequisite to downloading data from AWS, the only adjustment is the download tool - s5cmd instead of gsutil, and which column is used to get the URLs. Mentioning AWS in part 1 is somewhat out of place, because nothing is done wrt AWS in part 1.

— Reply to this email directly, view it on GitHub https://github.com/ImagingDataCommons/IDC-Tutorials/pull/23#issuecomment-1530754683, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGK2VIZ3MJINBQ6GGTHSVU3XEBQYLANCNFSM6AAAAAAXSKIEUU . You are receiving this because you authored the thread.Message ID: @.***>

bcli4d commented 1 year ago

Do you want me to work on other notebooks?

On Mon, May 1, 2023 at 6:41 PM Bill Clifford @.***> wrote:

OK. I'll let you do these notebooks.

On Mon, May 1, 2023 at 6:40 PM Andrey Fedorov @.***> wrote:

I think what needs to be changed is part 3 of the tutorial. There are no prerequisite to downloading data from AWS, the only adjustment is the download tool - s5cmd instead of gsutil, and which column is used to get the URLs. Mentioning AWS in part 1 is somewhat out of place, because nothing is done wrt AWS in part 1.

— Reply to this email directly, view it on GitHub https://github.com/ImagingDataCommons/IDC-Tutorials/pull/23#issuecomment-1530754683, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGK2VIZ3MJINBQ6GGTHSVU3XEBQYLANCNFSM6AAAAAAXSKIEUU . You are receiving this because you authored the thread.Message ID: @.***>

fedorov commented 1 year ago

Superseded by https://github.com/ImagingDataCommons/IDC-Tutorials/commit/46567f806db1d4a155c286d1ef0b98d8e244f9f3.

Sorry, just saw your comment re other notebooks. I've just updated part 3.