search

ImagingDataCommons / IDC-Tutorials

Self-guided notebook tutorials to help get started with using IDC
BSD 3-Clause "New" or "Revised" License
28 stars 14 forks source link

Add the Colab R test notebook #31

Closed denbonte closed 1 year ago

denbonte commented 1 year ago

As per discussion

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Gibbsdavidl commented 1 year ago

Looks good and all works for me.

A couple small comments:

fedorov commented 1 year ago

@denbonte can you please respond to @Gibbsdavidl comments? Thank you for the review, Dave!

denbonte commented 1 year ago

Hey All,

Thanks for the feedback @Gibbsdavidl 🙃

A couple small comments:

  • I think I would make the demo project ID a nonsense string.

Agreed - I changed this to a random string in the revised version.

  • Maybe want to explain why we would keep only the trackingIdentifier classes with more than 100 entries in the dataframe.

I tried to make it a bit explicit it was for visualization reasons!

  • Could name the y-axis label "Volume" and the title "Boxplot of Volumes by Tracking Identifier"

Done!

  • Could add a conclusion that tells people where to go next. ?

Done - I added a snippet on the IDC documentation page on files and metadata and some text!

Let me know if it looks good - and feel free to merge if yes!

fedorov commented 1 year ago

@denbonte I am sorry for not noticing this earlier, but I think we also should add a preamble, and point users to the getting started part 1 tutorial that will show them how to set up their own project. I will merge and add that myself. Thank you!