ImagingDataCommons / IDC-Tutorials

Self-guided notebook tutorials to help get started with using IDC
BSD 3-Clause "New" or "Revised" License
27 stars 14 forks source link

Add analysis notebook using MCMICRO #69

Open erindiel opened 3 months ago

erindiel commented 3 months ago

This notebook covers an example of image analysis using fluorescence WSI data from IDC as input to MCMICRO. Some caveats include:

Note that the markers.csv and params.yml files needed for MCMICRO analysis are included in this PR as well.

cc @melissalinkert @dclunie @fedorov

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

DanielaSchacherer commented 2 weeks ago

Hey Erin, I am Daniela, also part of the IDC team and Andrey asked me to check out your notebook and let you know my feedback! First of all, MCMICRO seems to be a pretty cool tool, that I did not come across so far. I tried to run the notebook locally on Windows and Linux. On Windows I was not successful unfortunately, s5cmd and docker did not work at all. However, on Linux, I was able to run your notebook with some adaptations (had to run part of the code from the command line instead from within the notebook).

I agree with all your points mentioned above. I think it could be valuable to have a list of requirements (nextflow, docker, java...) and maybe separate notebooks for Windows and Linux (can't say anything about MacOS). Alternatively, notebooks could be converted to a script + README, that explains what to expect from the code.

fedorov commented 2 weeks ago

@DanielaSchacherer thank you for the review!

@erindiel I am working on my review, and adding some small features to idc-index to help simplify some steps. I will follow up shortly.

DanielaSchacherer commented 2 weeks ago

As an update to what I had to adapt in the code: I had to manually create the folder /raw in MCMICRO-example-IDC/OME-TIFF and move markers.csv into MCMICRO-example-IDC/OME-TIFF. I guess that's not something I was supposed to do, is it?