search

ImagingDataCommons / dicomweb-client

Python client for DICOMweb RESTful services
https://dicomweb-client.readthedocs.io
MIT License
110 stars 38 forks source link

fix(orthanc): can't store a instance #52

Closed ziqiangxu closed 3 years ago

ziqiangxu commented 3 years ago
  1. Usually the quotation marks is not required
  2. The Orthanc can't store the instance if the quotation marks provided and Orthanc give a sucess response(This may be a bug of Orthanc-dicomweb-plugins)
hackermd commented 3 years ago

@ziqiangxu thanks for reporting the issue.

While it seems to be fine to not quote the value of the boundary parameter, we ran into issues with origin servers when not quoting the value.

RFC 2387 states:

Note that the parameter values will usually require quoting.

Therefore, origin servers shall be able to parse the header with quoted parameter values.

The issue with Orthanc was previously reported (see https://github.com/MGHComputationalPathology/dicomweb-client/issues/42) and should have been fixed in the meantime.