Fixes to SC pixel_spacing parameter - Githubissues

ImagingDataCommons / highdicom

High-level DICOM abstractions for the Python programming language

https://highdicom.readthedocs.io

MIT License

176 stars 37 forks source link

Fixes to SC pixel_spacing parameter #128

Closed CPBridge closed 3 years ago

CPBridge commented 3 years ago

There are a few issues with the SCImage pixel_spacing parameter:

It is type hinted as Union[Tuple[int, int], None], but its VR is DS, so it should be Union[Tuple[float, float], None]
There is no check that the input parameter has the correct multiplicity (shall be 2)
We should apply the auto_formatting to ensure a correct DS.

This PR fixes these three issues, plus a related tweak to the user guide docs