Attributes 'DICOMPrefix' 'FilePreamble' when initiating SOPClass

ImagingDataCommons / highdicom

High-level DICOM abstractions for the Python programming language

https://highdicom.readthedocs.io

MIT License

173 stars 37 forks source link

Attributes 'DICOMPrefix' 'FilePreamble' when initiating SOPClass #155

Closed erikogabrielsson closed 2 years ago

erikogabrielsson commented 2 years ago

Hi,

Highdicom sets the attribute 'DICOMPrefix' and 'FilePreamble' which is not in the pydicom dicom directory. This results in a warning by default or an exception if pydicom config.INVALID_KEYWORD_BEHAVIOR = "RAISE". I dont think you need to set those attributes as they are written by pydicoms dcmwrite?

hackermd commented 2 years ago

Good catch @erikogabrielsson. The behavior recently changed with the introduction of pydicom.dataset.FileMetaDataset. Do you want to send a PR?

CPBridge commented 2 years ago

@hackermd we fixed this didn't we? Can we close the issue?

hackermd commented 2 years ago

Indeed! We fixed this via #156 and it was included in release 0.15.1