ImagingDataCommons / highdicom

High-level DICOM abstractions for the Python programming language
https://highdicom.readthedocs.io
MIT License
168 stars 35 forks source link

Refactor Softcopy Presentation State constructors #166

Closed hackermd closed 2 years ago

hackermd commented 2 years ago

This PR introduces the following changes based on discussion on #139:

CPBridge commented 2 years ago

A note that we should update the explanation of the softcopy_voi_luts and modality_lut in the various SOPClass docstrings to make sure that it's clear that they will be copied from the referenced images if none are provided.

CPBridge commented 2 years ago

@hackermd it seems you have forgotten to add a test image called sm_image_grayscale.dcm, so tests are failing for me