search

ImagingDataCommons / highdicom

High-level DICOM abstractions for the Python programming language
https://highdicom.readthedocs.io
MIT License
168 stars 35 forks source link

Change LUT word length #171

Closed CPBridge closed 2 years ago

CPBridge commented 2 years ago

We can continue to discuss the right thing to do here, but here's the PR to switch to storing 1 byte per entry when bits allocated is 8, if we decide to use it. I vote for merging this

hackermd commented 2 years ago

I tend argue that we should only do this if we can set VR to "OB". Otherwise, receiving applications will likely decode the data incorrectly.

However, that would require chancing the dictionary of pydicom and since that is auto-generated from the table in the standard, it would require a change in the standard.

I would leave it as is until we have further clarity. It's currently definitely not wrong. The VR is OW and the data is 16-bit.

CPBridge commented 2 years ago

We have decided to disallow 8bit LUTs entirely for the time being. See #177. Closing this.