search

ImagingDataCommons / highdicom

High-level DICOM abstractions for the Python programming language
https://highdicom.readthedocs.io
MIT License
168 stars 35 forks source link

Fix bugs in implementation of Advanced Blending Presentation State IOD #179

Closed hackermd closed 2 years ago

hackermd commented 2 years ago

There is currently a check that prevents reference of images from more than one series in presentation state instances. However, in case of the DICOM Advanced Blending Representation State IOD, images from more than one series may be blended together (as long as the images are defined in the same frame of reference). This PR relaxes the check to allow the referencing images from multiple series.

The PR also fixes the inclusion of attributes of the Palette Color Lookup Table Macro in the Advanced Blending Sequence. The attributes should be added to an item of the Palette Color Lookup Table Sequence rather than the item of the Advanced Blending Sequence.

CPBridge commented 2 years ago

Might be missing something big here, but I can't find the PaletteColorLookupTableSequence in the location that you are now putting it (items of the advanced blending sequence). Can you clarify?

hackermd commented 2 years ago

It doesn't exist yet :) I have been working with David on a correction proposal (CP) to include it into the standard. The changes in this PR are necessary to comply with the CP.