Closed Eschivo closed 2 years ago
@EliaSchiavon thank you very much for answering the question on SO and for reporting the issue. I agree with your assessment. It is probably better for highdicom.io.ImageFileReader
to not fail upon construction to allow reading of image frames without color correction.
I'm seeing this only now, I'll give it a try anyway today. Thank you for your work!
@hackermd did you mean to merge #189 ? it has not been merged yet?
I recently came across this SO question and as a solution, I answered suggesting the usage of this package. However, I noticed that since the attributes
ICCProfile
andOpticalPathSequence
are not present, it's not possible to inspect the metadata of the file provided by the OP at all. Furthermore, since the code works correctly with thecorrect_color
option set to False inread_frame
, why not print a warning when reading metadata instead of raising theAttributeError
and raise it subsequently in theread_frame
function ifcorrect_color
is True? I think that it's better to have the possibility to inspect, view and print all the available metadata rather than stop the code execution if one is missing. As a disclaimer, I'm not a DICOM expert so maybe there's a reason to do the things in this way that I can't actually understand.