Closed CPBridge closed 1 year ago
Note also, there were previously a bunch of _from_dataset
methods that did this but did not expose it publicly. In these cases I have essentially kept the same behaviour but now made it public via the copy
parameter to the public from_dataset
method. The result is a consistent API for all from_dataset
methods in the library
Tweaked all
from_dataset
methods to accept a new booleancopy
parameter (defaultTrue
) in order to skip the copy operation to improve performance. IfFalse
, the dataset parameter is altered in place. This is now used in thesegread
method, and dramatically improves the performance there.@pieper this should cut around 25% off your large seg benchmark time based on my testing