ImagingDataCommons / highdicom

High-level DICOM abstractions for the Python programming language
https://highdicom.readthedocs.io
MIT License
164 stars 34 forks source link

Tweaks Following Segmentation Update #224

Closed CPBridge closed 1 year ago

CPBridge commented 1 year ago

Found that after the major update of #208 I accidentally left an unnecessary join in the database logic (from the period when I was keeping a foreign key in the main frames LUT rather than simply keeping the SOP Instance UID there). This doesn't change the outcome, just takes a more direct route with one fewer join.

Also wanted to sanity check the logic about missing frames. Turns out all is fine but thought I might as well push the improved test I wrote.