search

ImagingDataCommons / highdicom

High-level DICOM abstractions for the Python programming language
https://highdicom.readthedocs.io
MIT License
179 stars 37 forks source link

TypeError in _build_bot function with pydicom.filebase.DicomBytesIO #313

Closed denesd closed 4 weeks ago

denesd commented 1 month ago

In pydicom 3.0.1 DicomBytesIO's and DicomFileLike read function changed an only accepts one argument. The current implementation https://github.com/ImagingDataCommons/highdicom/blob/master/src/highdicom/io.py#L188 seems to be compatible with the 2.4.4 based DicomIO.

The following error is raised:

first_two_bytes = fp.read(2, True)
E           TypeError: read expected at most 1 argument, got 2
CPBridge commented 1 month ago

Thanks for reporting this issue @denesd, hopefully this should be a simple fix. I'll take a look in the next few days

CPBridge commented 1 month ago

Hi @denesd, could you please test whether #314 fixes your issue?

denesd commented 4 weeks ago

Hi @CPBridge , I've tested the fix and it seems to be working as expected :100:

CPBridge commented 4 weeks ago

Closed by #314