Open afshinmessiah opened 4 years ago
The complete list of missing modules:
These are all retired attributes containing x
in the group or element part of the tag. pydicom stores those attributes not in the pydicom._dicom_dict.DicomDictionary
but in a separate pydicom._dicom_dict.RepeatersDictionary
and looking up the keyword corresponding to the tag requires a workaround.
Should be fixed with 6fd6e8ef67439cd7fa0f67724210bce10d79175b.
@afshinmessiah could you please confirm? It would also be great if you could add a few unit tests.
I checked the newly generated _iod and _module files. Some modules are missing:
I've not added unit-tests yet but I will soon.
Yes, the attributes in Current Frame Functional Groups Module with group 0006
are skipped, since they are not part of the DICOM Dictionary.
We could handle that special case separate if needed. Out of curiosity, what do you need these attributes for?
No, I don't need them. I just ran a test on all iods and modules to see if all modules are included.
No, I don't need them. I just ran a test on all iods and modules to see if all modules are included.
Ok. Thanks for the effort. I can include them for completeness (by hardcoding 0006
attributes).
If you already have test procedures to evaluate completeness, it would be great if we could include them into the unit tests located in /tests
.
In the list of iods ( _iod.py), "overlay-plane" is listed as a module for pet-image. In _module.py file though, there is no such module as "overlay-plane" to get the list of its attributes.