ImagingDataCommons / highdicom

High-level DICOM abstractions for the Python programming language
https://highdicom.readthedocs.io
MIT License
170 stars 35 forks source link

Incorrectly named IOD_MODULE_MAP key for positron emission tomography #38

Closed vanossj closed 3 years ago

vanossj commented 3 years ago

https://github.com/MGHComputationalPathology/highdicom/blob/a9f3916a9b98e09ff5f359fe77f508746e56b730/src/highdicom/_iods.py#L7825

Which SOPInstanceUID is the key pet-image supposed to link to? I don't see a pet image storage on the official list.

Is it referring to Positron Emission Tomography Image Storage SOP 1.2.840.10008.5.1.4.1.1.128?

If so the key should be changed to positron-emission-tomography-image

If this isn't the issue what key in IOD_MODULE_MAP does SOP 1.2.840.10008.5.1.4.1.1.128 map to?

hackermd commented 3 years ago

@vanossj thank you for reporting the issue and for fixing it. We will draft a new release within the next days and make the new version available on PyPI.