fix: Remove unneeded importlib metadata dependency

ImagingDataCommons / idc-index-data

Python package providing the index to query and download data hosted by the NCI Imaging Data Commons

MIT License

1 stars 4 forks source link

fix: Remove unneeded importlib metadata dependency #12

Closed jcfr closed 8 months ago

jcfr commented 8 months ago

Remove unneeded importlib_metadata dependency with Python < 3.10

It turns out that the importlib.metadata.distribution() function is available in Python 3.8 and 3.9 where it is implemented in Lib/importlib/metadata.py and not Lib/importlib/metadata/__init__.py.

For more details:

https://github.com/scikit-build/cmake-python-distributions/pull/474#discussion_r1539553024

jcfr commented 8 months ago

@vkt1414 If you approve the pull request, now that we have the possibility to enable Auto-merge on a per pull request basis, it will then get automatically merged :pray:

I also just added you a reviewed. For context, I initially assigned the issue to you instead of adding you as a reviewer.

vkt1414 commented 8 months ago

thank you, @jcfr ! We are still learning how the pyproject.toml is put together. So, as long as the checks are working, we are okay!