search

ImagingDataCommons / idc-index-data

Python package providing the index to query and download data hosted by the NCI Imaging Data Commons
MIT License
1 stars 4 forks source link

Incorrect release version is used in PyPI upload when fix release updated #18

Closed fedorov closed 4 months ago

fedorov commented 4 months ago

Instead of 17.0.1 the workflow is using 17.0.0 somehow!

https://github.com/ImagingDataCommons/idc-index-data/actions/runs/8609215231/job/23592839431

image
fedorov commented 4 months ago

It worked, thank you @vkt1414!

It would be nice to figure out how to publish without changing that line, if possible. If we can publish without manually writing release into that file with idc-index, is there a reason why it is not possible in this package?

vkt1414 commented 4 months ago

It was done to ensure reproducibility if one wants to install from the source.

I'm afraid we are also not building on JC's work here.

https://github.com/ImagingDataCommons/idc-index-data/blob/main/scripts/python/update_idc_index_version.py