Closed DanielaSchacherer closed 2 months ago
clinical_index
: https://github.com/ImagingDataCommons/idc-index/blob/main/idc_index/index.py#L100-L104 (may be irrelevant if the final comment is addressed)
# TODO: find a more elegant way to automate the following
AI to the rescue: https://www.perplexity.ai/search/write-python-code-that-iterate-XY9ppywbQFSRnOpgbwx_uQ (I have not tested the code, definitely needs to be tested!).
The AI-suggested part is a bit controversial, but I don't know if there is a better alternative. This probably needs more research and exploration. It does not need to be part of this PR, can keep in TODO, maybe include a link to this PR in the code so it can be followed up later.
AI to the rescue: https://www.perplexity.ai/search/write-python-code-that-iterate-XY9ppywbQFSRnOpgbwx_uQ (I have not tested the code, definitely needs to be tested!).
Yes, I asked another AI and got a similar suggestion with a strong recommendation to not do this in production code. That's why I added the comment and kept the code as it was.
- might be good to add a test!
If it's okay, I would like to keep that for the next PR when we automate this process.
Looks good, but do you think you could squash commits into a single one and force-push?
$ git rebase -i HEAD~3
Sorry for nit-picking, but can you do git commit --amend
and remove the ENH lines? I do not think they add any value. You could have also removed those as part of the rebase operation.
I should update contribution instructions to add those details.
I wasn't aware those lines were still there. They should be gone now!