search

ImagingDataCommons / idc-slim

Interoperable slide microscopy viewer for thin clients (CORE REPO)
Apache License 2.0
0 stars 0 forks source link

Add new features available in upstream to this fork #22

Closed hackermd closed 3 years ago

hackermd commented 3 years ago

@wlongabaugh this PR adds the features recently introduced into the master branch of upstream slim repo. Note that the new features to take effect, changes to the configuration will be necessary.

I'd recommend creating a separate idc.js configuration file instead of modifying the local.js (the latter is intended to work with the Dockerfile and docker-compose.yml configurations).

hackermd commented 3 years ago

@igoroctaviano do you know why the check fails? Should these tests even run in this fork?

hackermd commented 3 years ago

You want to use a configuration like this:

window.config = {
  path: "/slim",
  servers: [
    {
      id: "idc",
      url: "",  // URL of DICOMweb proxy
      write: false
    }
  ],
  renderer:
  {
    retrieveRendered: false
  },
  annotations: [ ],
  disableWorklist: true,
  disableAnnotationTools: true
};
igoroctaviano commented 3 years ago

@igoroctaviano do you know why the check fails? Should these tests even run in this fork?

Actually, the deploy failed because it's missing the firebase service acc. Error: Input required and not supplied: firebaseServiceAccount maybe something specific to IDC pipeline? @wlongabaugh

hackermd commented 3 years ago

@igoroctaviano do you know why the check fails? Should these tests even run in this fork?

Actually, the deploy failed because it's missing the firebase service acc. Error: Input required and not supplied: firebaseServiceAccount maybe something specific to IDC pipeline? @wlongabaugh

I think we only configured the application/action for the main slim repo, but not for the IDC fork.

igoroctaviano commented 3 years ago

@igoroctaviano do you know why the check fails? Should these tests even run in this fork?

Actually, the deploy failed because it's missing the firebase service acc. Error: Input required and not supplied: firebaseServiceAccount maybe something specific to IDC pipeline? @wlongabaugh

I think we only configured the application/action for the main slim repo, but not for the IDC fork.

I think thats right, we need to migrate the firebase config files.

wlongabaugh commented 3 years ago

The viewer is built and deployed to a static bucket using our CircleCI build process. The firebase config files should not be triggered in IDC.