Update to Slim 0.7.1 - Githubissues

Punzo commented 2 years ago

New features

Support DICOM Advanced Blending Presentation State to parametrize the display of multiplexed IF microscopy images;
Add key bindings for annotations tools;
Enable configuration of tile preload;
Enable configuration of annotation geometry type per finding;
Expose equipment metadata in user interface.

Enhancements

Improve default presentation of multiplexed IF microscopy images in the absence of presentation state instances;
Correctly configure DCM4CHEE Archive to use reverse proxy URL prefix for BulkDataURI in served metadata;
Enlarge display settings interfaces and add input fields for opacity, VOI limits, and colors;
Update dicom-microscopy-viewer version to use web workers for frame decoding/transformation operations;
Add button for user logout;
Disable optical path selection when a presentation state has been selected.

Bug fixes

Fix parsing of URL path upon redirect after successful authentication/authorization;
Fix configuration of optical path display settings when switching between presentation states;
Fix caching of presentation states and for selection via drop-down menu.

Security

Update dependencies with critical security issues.

fedorov commented 2 years ago

Per discussions with @hackermd, we will need to update Slim sandbox and test it against the updated HTAN with presentation states. Let's wait merging this PR until we are done with that sandbox testing.

hackermd commented 2 years ago

@Punzo thanks for preparing the PR. Could you please remove the configuration files in .github/workflows? The deploy pipelines should not be run on the fork

hackermd commented 2 years ago

@Punzo I just released version 0.7.1. Could you kindly update the PR to include the recent bug fixes?

Punzo commented 2 years ago

@Punzo I just released version 0.7.1. Could you kindly update the PR to include the recent bug fixes?

done in https://github.com/ImagingDataCommons/slim/pull/61/commits/2152eeb7ad6fbc4c6e98934c767414358d970287

wlongabaugh commented 2 years ago

@Punzo @hackermd I have merged to master, but the version now deployed reads 0.7.0, not 0.7.1.

hackermd commented 2 years ago

@Punzo @wlongabaugh @fedorov I meanwhile released version 0.7.2 because we realized that we had change to the encoding of presentation states after consultation with @dclunie. Could you please update the fork to the latest version?

Punzo commented 2 years ago

@wlongabaugh @hackermd done in https://github.com/ImagingDataCommons/slim/pull/62

fedorov commented 2 years ago

I have merged to master, but the version now deployed reads 0.7.0, not 0.7.1.

@wlongabaugh as mentioned in https://github.com/ImagingDataCommons/slim/pull/61#issuecomment-1144842858 above, we planned to test this in a sandbox against the re-converted TCGA/CPTAC/NLST and HTAN with presentation states before merging. It's not a huge deal here I guess, but going forward we should try to make sure this kind of communication does not slip through the cracks.

ImagingDataCommons / idc-slim

Update to Slim 0.7.1 #61