search

ImagingDataCommons / libdicom

C library for reading DICOM files
https://libdicom.readthedocs.io
MIT License
16 stars 7 forks source link

meson: fixes for using libdicom as a subproject #30

Closed bgilbert closed 1 year ago

bgilbert commented 1 year ago

Add an override_dependency() call for libdicom. This is the modern way of propagating dependencies out of subprojects, allowing a parent project to use dependency('libdicom') rather than dependency('libdicom', fallback : ['libdicom', 'libdicom_dep']).

Also skip the dist script if we're a subproject. Dist scripts can't be used in subprojects before Meson 0.58.0, and in our case, it's not clear that it makes sense to do so. The parent project probably doesn't want to ship our documentation, may not have vendored our dotfiles, and may not want us skipping files they did choose to vendor.

jcupitt commented 1 year ago

Sorry for the delay -- my household is full of covid. It's been a difficult few weeks :(