ImagingDataCommons / libdicom

C library for reading DICOM files
https://libdicom.readthedocs.io
MIT License
16 stars 7 forks source link

Repository configuration #33

Closed bgilbert closed 1 year ago

bgilbert commented 1 year ago

After the move to ImagingDataCommons, it appears the repository configuration has changed a bit. I have some limited access to the repo settings, so I've made these changes:

I can revert any of those changes if desired.

It'd be good to enable branch protection and required checks, too, but I don't have access to do that.

hackermd commented 1 year ago

The repository is now under an organization, which gives us finer control over repository settings. The master branch is protected and required checks should be in place. We can further fine tune those settings if desired.

hackermd commented 1 year ago

@bgilbert you also suggested renaming master to main (#28). Maybe now would be a good time to do that?

bgilbert commented 1 year ago

After required checks are enabled, individual checks need to be manually added to the required list. You'd need to search for each of the three checks in the search box, add them, then save the branch protection settings.

Renaming the branch sounds good. I don't have access to do that myself, but I think you can go ahead when ready.

bgilbert commented 1 year ago

(You may want to disable "require branches to be up-to-date before merging". I think it's on by default, and it can require extra rebasing that seems pointless for a project of this size.)

hackermd commented 1 year ago

This setting appears to be disabled. I also added the checks.

hackermd commented 1 year ago

@bgilbert let me know if you would like add further checks.

bgilbert commented 1 year ago

It looks like only the macOS one is marked required currently. I'd be in favor of making the Ubuntu and Windows ones required also.

hackermd commented 1 year ago

Good catch. I thought it would add all three at once. All three should be required now.