search

ImagingDataCommons / libdicom

C library for reading DICOM files
https://libdicom.readthedocs.io
MIT License
16 stars 8 forks source link

wrong tag for AS check? #42

Closed jcupitt closed 1 year ago

jcupitt commented 1 year ago

Hey @hackermd, sorry to ping you, I'm not sure I have a current email address for you :(

I'm revising the parser and tests and noticed this:

https://github.com/ImagingDataCommons/libdicom/blob/main/tests/check_dicom.c#L210-L214

Could this be a copy-paste typo from the previous test? Should the tag be 0x00101010?

jcupitt commented 1 year ago

Yes, looks like there was an error in the test suite.

hackermd commented 1 year ago

Sorry for the delayed response @jcupitt. Glad you found the error.