search

ImagingDataCommons / libdicom

C library for reading DICOM files
https://libdicom.readthedocs.io
MIT License
16 stars 8 forks source link

Windows build fixes #46

Closed bgilbert closed 1 year ago

bgilbert commented 1 year ago

Include share.h from dicom-io.c on Windows to fix missing definition for _SH_DENYWR.

Don't dllexport/dllimport when building libdicom as a static library. In this case, we don't want callers to try to mangle our symbols to reference them from a DLL import library, and we don't want to include our symbols in the exports of a larger DLL that we might be linked into.

jcupitt commented 1 year ago

I've also merged these changes to my libdicom fork:

https://github.com/jcupitt/libdicom

Which should have everything and be up to date.