search

ImagingDataCommons / libdicom

C library for reading DICOM files
https://libdicom.readthedocs.io
MIT License
15 stars 7 forks source link

Update to v0.2 #50

Closed jcupitt closed 1 year ago

jcupitt commented 1 year ago

Update libdicom to v0.2, the version used by openslide at the end of phase 1.

bgilbert commented 1 year ago

@hackermd I'm afraid I don't have the review bandwidth at the moment, so please go ahead and review the implementation as well.

jcupitt commented 1 year ago

Thanks for the detailed api review Markus. I'm on holiday this week, I'll work on it when I get back.

jcupitt commented 1 year ago

Sorry, it took me too long to discover the new github "batch accept" feature.

I incorporated review comments and I've left the ones I was unsure about open. I've bumped the version to 0.3.0, since the suggested API changes will break the openslide DICOM vendor loader.

I think this is ready for another look now. Thanks!

jcupitt commented 1 year ago

Great!

I almost have the next version ready to go, so I'm afraid there's another large PR coming RSN :(