ImagingDataCommons / slim

Interoperable web-based slide microscopy viewer and annotation tool
https://imagingdatacommons.github.io/slim/
Apache License 2.0
111 stars 36 forks source link

Update dicom-microscopy-viewer dependency #157

Closed cgorman closed 1 year ago

cgorman commented 1 year ago

Updates dicom-microscopy-viewer to 0.45.0 which fixes JPEG 2000 decoding errors

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit 8c54f6b):

https://idc-external-006--pr157-cg-update-dmv-rm5llbdw.web.app

(expires Wed, 07 Jun 2023 15:49:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 88aacecd98ba54d2f9c8d201a9444e43d1ad8307

cgorman commented 1 year ago

Oh I guess we need to do similar mapping here that we did to make the DMV tests work. I'll get a fix pushed in a bit.

fedorov commented 1 year ago

@igoroctaviano can you take a glance at this? I do not think I can do a meaninfgul review.

cgorman commented 1 year ago

It is preventing me from merging due to a "missing github-pages deployment", but the github-pages deployment ran successfully. I don't have admin rights, can somebody update the project settings? Maybe it is checking for the old herrmanlab.github.io URL or something.

fedorov commented 1 year ago

@cgorman I was able to merge!

cgorman commented 1 year ago

Great, thanks! I'll publish as a new release now