ImagingDataCommons / slim

Interoperable web-based slide microscopy viewer and annotation tool
https://imagingdatacommons.github.io/slim/
Apache License 2.0
118 stars 36 forks source link

Investigate inability to access bulk annotations via Google Healthcare API beta #185

Closed fedorov closed 8 months ago

fedorov commented 9 months ago

@igoroctaviano you should have the permissions - let me know otherwise!

Note the "beta" in the URL - bulk data is not supported yet in the production "v1" of GHC API.

https://healthcare.googleapis.com/beta/projects/idc-external-031/locations/us-central1/datasets/beta-test-bulk-ann/dicomStores/beta-test-bulk-ann-store/dicomWeb

I was using this instance for testing: https://andrey-slim-test.web.app/ (it is not the latest version of the code).

igoroctaviano commented 8 months ago

Updates:

The viewer retrieves the results correctly using the new API but this dataset in particular was not loading correctly. The DimensionOrganizationType is TILED_SPARSE but PlanePositionSlideSequence was missing from both Per frame and SharedFunctionalGroupsSequence which causes parsing errors in dicom-microscopy-viewer. The tag was missing both from the request response and the binary file.

Verify results:

Warning - Value dubious for this VR - (0x0010,0x0010) PN Patient's Name  PN [1] = <TCGA-02-0001> - Retired Person Name form
VLWholeSlideMicroscopyImage
Error - Value is zero for value 1 of attribute <Slice Thickness>
Error - Value is zero for value 1 of attribute <Imaged Volume Depth>
fedorov commented 8 months ago

Per discussion today, let's restart this experiment and create a new DICOM store with the data we know is valid. @igoroctaviano will follow up with @CPBridge to get a valid ANN sample and a corresponding SM image.

Per clarification from Vivian:

The DICOM store can be created at any endpoint/using any version of the API. The bulk retrieve feature is the only thing that needs to be called/envoked using the beta endpoint. Documentation can be found at: https://cloud.google.com/healthcare-api/docs/reference/rest/v1beta1/projects.locations.datasets.dicomStores.studies.series.instances.bulkdata/retrieveBulkdata

igoroctaviano commented 8 months ago

@fedorov

The problem I mentioned earlier was for graphic type point. For polygons it works fine.

fedorov commented 8 months ago

Great news, thank you!