setup preview for PR

[Punzo]

look into netlify as OIHF viewer

[Punzo]

Igor has done it with firebase, see fork https://github.com/igoroctaviano/slim/pull/3/checks?check_run_id=2621971527

[igoroctaviano]

Tested Firebase Deploy both for OHIF fork and SLIM:

• OHIF:
  • Preview: https://idc-slim--pr5-test-3wlngske.web.app/
  • PR Pipeline: https://github.com/igoroctaviano/Viewers/pull/5/checks?check_run_id=2622310885

• SLIM:

  • Preview: https://idc-slim--pr3-test-cawctd67.web.app/
  • PR Pipeline: https://github.com/igoroctaviano/slim/pull/3/checks?check_run_id=2621971527

  For projects using Netlify only for deploy preview, we could just switch to Firebase Hosting.

[hackermd]

@igoroctaviano The Slim preview currently fails for me due to CORS headers.

[igoroctaviano]

@igoroctaviano The Slim preview currently fails for me due to CORS headers.

@hackermd we decided to go with independent servers? e.g. dcmjs? which server you're using?

[pieper]

Igor can you try the server I emailed about earlier?

https://idc-external-006.uc.r.appspot.com/studies

On Thu, May 20, 2021 at 6:31 PM Igor Octaviano @.***> wrote:

@igoroctaviano https://github.com/igoroctaviano The Slim preview currently fails for me due to CORS headers.

@hackermd https://github.com/hackermd we decided to go with independent servers? e.g. dcmjs? which server you're using?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MGHComputationalPathology/slim/issues/19#issuecomment-845522681, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA6Y7OIHE2OLVQDFSNSFADTOWESPANCNFSM44HBOCGQ .

[igoroctaviano]

https://idc-external-006.uc.r.appspot.com/studies

@pieper just tested and its working fine. Here: https://idc-slim--pr3-test-cawctd67.web.app/ @hackermd can you use this one then?

[pieper]

Excellent, thanks Igor.

As you play with this let me know if it feels like the proxy slows it down compared to hitting the dicomweb endpoint directly.

-Steve

On Fri, May 21, 2021 at 2:01 PM Igor Octaviano @.***> wrote:

https://idc-external-006.uc.r.appspot.com/studies

@pieper https://github.com/pieper just tested and its working fine. Here: https://idc-slim--pr3-test-cawctd67.web.app/ @hackermd https://github.com/hackermd can you use this one then?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MGHComputationalPathology/slim/issues/19#issuecomment-846139040, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA6Y7MYUJABQNVTJO5RM7DTO2NWRANCNFSM44HBOCGQ .

[igoroctaviano]

@hackermd @pieper which google acc we are going to use to set up the preview? if there's one for slim already, you can generate the firebase config with the following steps:

• In the repo folder, run: firebase init hosting
• Follow the CLI prompts, and the command will automatically take care of setting up the GitHub Action. In this step, you'll need to set up the public folder to build and define a build/deploy script if any
• Commit and push these changes to master
• Done! deploy preview should be triggered on every pull request _{Reference: https://firebase.google.com/docs/hosting/github-integration}

[pieper]

which google acc we are going to use

Does acc mean account? I don't think it matters. I believe the use case will stay in the free tier, but if there's a concern it won't then @hackermd could use an account from his idc-external-006 project.

[Punzo]

this was done by @igoroctaviano in https://github.com/MGHComputationalPathology/slim/pull/34, closing!