ImagingDataCommons / slim

Interoperable web-based slide microscopy viewer and annotation tool
https://imagingdatacommons.github.io/slim/
Apache License 2.0
111 stars 36 forks source link

WIP: feat 194 class based color settings #213

Open pedrokohler opened 3 weeks ago

pedrokohler commented 3 weeks ago

Adding the ability to edit annotation groups colors based on their categories and types. Solves https://github.com/ImagingDataCommons/slim/issues/194.

https://github.com/ImagingDataCommons/slim/assets/22822446/168582d3-2832-4d9c-a6b0-98b21834bf30

github-actions[bot] commented 3 weeks ago

Visit the preview URL for this PR (updated for commit 84badb8):

https://idc-external-006--pr213-feat-194-class-based-5s1uxkrm.web.app

(expires Fri, 21 Jun 2024 20:45:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 88aacecd98ba54d2f9c8d201a9444e43d1ad8307

fedorov commented 2 weeks ago

I am unable to point the preview instance to a GCP DICOM store - I get this error:

image

pedrokohler commented 2 weeks ago

I am unable to point the preview instance to a GCP DICOM store - I get this error:

image

@fedorov can you give me an example of a server url you're trying to use?

fedorov commented 2 weeks ago

projects/idc-dev-etl/locations/us-central1/datasets/idc/dicomStores/annotated_rms-original-and-annotations-wc-temp-20240122

pedrokohler commented 2 weeks ago

projects/idc-dev-etl/locations/us-central1/datasets/idc/dicomStores/annotated_rms-original-and-annotations-wc-temp-20240122

You have to add a /dicomWeb at the end (if you haven't)

When you do that we're getting a 401 error, probably because this dataset requires google authentication but the config file the environment is using does not ask you to login with google.

We're seeing how to change this right now... I'll let you know.

fedorov commented 2 weeks ago

Yes, you also should add the prefix. The full url is this: https://healthcare.googleapis.com/v1/projects/idc-dev-etl/locations/us-central1/datasets/idc/dicomStores/annotated_rms-original-and-annotations-wc-temp-20240122/dicomWeb. I just copied from the console. What I tested and what didn't work for me had both the prefix and suffix.