ImagingDataCommons / slim

Interoperable web-based slide microscopy viewer and annotation tool
https://imagingdatacommons.github.io/slim/
Apache License 2.0
118 stars 36 forks source link

feat - 194: ROI class based color settings #227

Closed pedrokohler closed 1 month ago

pedrokohler commented 1 month ago

Adding the ability to edit ROI colors based on their categories and types. Solves https://github.com/ImagingDataCommons/slim/issues/194.

github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit c4213c3):

https://idc-external-006--idc-slim-preview-bhe6cro3.web.app

(expires Thu, 22 Aug 2024 17:05:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 88aacecd98ba54d2f9c8d201a9444e43d1ad8307

fedorov commented 1 month ago

Looks great testing with https://healthcare.googleapis.com/v1/projects/idc-dev-etl/locations/us-central1/datasets/idc/dicomStores/annotated_rms-original-and-annotations-wc-temp-20240122/dicomWeb (specifically, RMS2455 is a good example).

Few suggestions:

pedrokohler commented 1 month ago

@fedorov

  • It is nice that you show SCT codes in tooltips for types - can you do the same for categories?

Isn't it showing on your end? For me it shows

image

Or do you mean something else?

Can you populate default colors to allow differentiation between different types?

I'll work on this.

fedorov commented 1 month ago

Isn't it showing on your end? For me it shows

Indeed, it does show! I guess I was confused by the colors. Why is category black and type green-blue? I think all should be black

pedrokohler commented 1 month ago

@fedorov you can check the changes you required here

https://idc-external-006.web.app/

fedorov commented 1 month ago

@pedrokohler this is perfect, great work! Good to go from my perspective.

igoroctaviano commented 1 month ago
Screenshot 2024-08-28 at 22 14 37

@pedrokohler can you please use the link below and check if you can replicate this error?

https://healthcare.googleapis.com/v1beta1/projects/idc-external-031/locations/us-east1/datasets/2d-bulk-ann/dicomStores/2d-bulk-ann/dicomWeb

igoroctaviano commented 1 month ago

@pedrokohler Same error trying this one: https://healthcare.googleapis.com/v1beta1/projects/idc-external-031/locations/us-central1/datasets/pan-cancer-example-bulk-anns-2024-01-18/dicomStores/pan-cancer-example-bulk-anns-2024-01-18/dicomWeb