Closed pedrokohler closed 1 month ago
Visit the preview URL for this PR (updated for commit c4213c3):
https://idc-external-006--idc-slim-preview-bhe6cro3.web.app
(expires Thu, 22 Aug 2024 17:05:48 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: 88aacecd98ba54d2f9c8d201a9444e43d1ad8307
Looks great testing with https://healthcare.googleapis.com/v1/projects/idc-dev-etl/locations/us-central1/datasets/idc/dicomStores/annotated_rms-original-and-annotations-wc-temp-20240122/dicomWeb (specifically, RMS2455 is a good example).
Few suggestions:
@fedorov
- It is nice that you show SCT codes in tooltips for types - can you do the same for categories?
Isn't it showing on your end? For me it shows
Or do you mean something else?
Can you populate default colors to allow differentiation between different types?
I'll work on this.
Isn't it showing on your end? For me it shows
Indeed, it does show! I guess I was confused by the colors. Why is category black and type green-blue? I think all should be black
@fedorov you can check the changes you required here
@pedrokohler this is perfect, great work! Good to go from my perspective.
@pedrokohler can you please use the link below and check if you can replicate this error?
Adding the ability to edit ROI colors based on their categories and types. Solves https://github.com/ImagingDataCommons/slim/issues/194.