Closed sglanger closed 9 years ago
shadowdoc
commented
9 years ago Steve - when I look at this pull request it only includes one commit, and that commit deletes two files. One of which, BreastDx-01-0003/MedicationPrescription/levothyroxine.medication_prescription.json was created by me and should be a valid JSON object for this patient. The original levothyroxine JSON has been moved to the medication folder under the dataset at large.
Please help me if I'm horribly confused.
sglanger
commented
9 years ago levothyroxine.medication_prescription.json was not deleted it was renamed medication_prescription..breastdx.json
to be consistent with all the other json files you will find in the DxReports and other folders
It would probably be simpler if I just mailed them to you. Here they are
From: Marc Kohli [mailto:notifications@github.com] Sent: Monday, February 16, 2015 4:45 PM To: shadowdoc/siim-dataset Cc: Langer, Steve G., Ph.D. Subject: Re: [siim-dataset] re-synched, updated json reports with "patient" name (#3)
Steve - when I look at this pull request it only includes one commit, and that commit deletes two files. One of which, BreastDx-01-0003/MedicationPrescription/levothyroxine.medication_prescription.json was created by me and should be a valid JSON object for this patient. The original levothyroxine JSON has been moved to the medication folder under the dataset at large.
Please help me if I'm horribly confused.
Reply to this email directly or view it on GitHubhttps://github.com/shadowdoc/siim-dataset/pull/3#issuecomment-74584228.
shadowdoc
commented
9 years ago Fine if you want to e-mail them, but they can't be attached through github.
If you look at this URL -> https://github.com/shadowdoc/siim-dataset/pull/3/files
There are just two deletions in your commit, there are no additions.
--Marc
On Tue, Feb 17, 2015 at 8:22 AM, sglanger notifications@github.com wrote:
levothyroxine.medication_prescription.json was not deleted it was renamed medication_prescription..breastdx.json
to be consistent with all the other json files you will find in the DxReports and other folders
It would probably be simpler if I just mailed them to you. Here they are
From: Marc Kohli [mailto:notifications@github.com] Sent: Monday, February 16, 2015 4:45 PM To: shadowdoc/siim-dataset Cc: Langer, Steve G., Ph.D. Subject: Re: [siim-dataset] re-synched, updated json reports with "patient" name (#3)
Steve - when I look at this pull request it only includes one commit, and that commit deletes two files. One of which, BreastDx-01-0003/MedicationPrescription/levothyroxine.medication_prescription.json was created by me and should be a valid JSON object for this patient. The original levothyroxine JSON has been moved to the medication folder under the dataset at large.
Please help me if I'm horribly confused.
Reply to this email directly or view it on GitHub< https://github.com/shadowdoc/siim-dataset/pull/3#issuecomment-74584228>.
— Reply to this email directly or view it on GitHub https://github.com/shadowdoc/siim-dataset/pull/3#issuecomment-74666409.
shadowdoc
commented
9 years ago You probably just forgot to add the new files. Since they weren't being tracked by git they need to be specifically added. If you just git add, and then git push to your repo they should be added to this pull request automagically.
sglanger
commented
9 years ago um, I did a
"git commit -a"
From: Marc Kohli [mailto:notifications@github.com] Sent: Tuesday, February 17, 2015 7:29 AM To: shadowdoc/siim-dataset Cc: Langer, Steve G., Ph.D. Subject: Re: [siim-dataset] re-synched, updated json reports with "patient" name (#3)
You probably just forgot to add the new files. Since they weren't being tracked by git they need to be specifically added. If you just git add, and then git push to your repo they should be added to this pull request automagically.
Reply to this email directly or view it on GitHubhttps://github.com/shadowdoc/siim-dataset/pull/3#issuecomment-74667291.
shadowdoc
commented
9 years ago http://git-scm.com/docs/git-commit says:
-a --all Tell the command to automatically stage files that have been modified and deleted, but new files you have not told Git about are not affected.
I've always found git add -p much more useful as you can tell exactly what's being added to the stage.
sglanger
commented
9 years ago OK, try it now
shadowdoc
commented
9 years ago Reopening this pull request
shadowdoc
commented
9 years ago Will merge, thanks!
shadowdoc
commented
9 years ago Also - git mv is your friend when renaming.
sglanger
commented
9 years ago thanks
Are you getting together the histories of the other patient's?
From: Marc Kohli [mailto:notifications@github.com] Sent: Tuesday, February 17, 2015 8:33 AM To: shadowdoc/siim-dataset Cc: Langer, Steve G., Ph.D. Subject: Re: [siim-dataset] re-synched, updated json reports with "patient" name (#3)
Also - git mv is your friend when renaming.
Reply to this email directly or view it on GitHubhttps://github.com/shadowdoc/siim-dataset/pull/3#issuecomment-74675912.
shadowdoc
commented
9 years ago Yes, working on it.
I've got Matt Morgan working on reports for the breast patient. I've downloaded the images for the other patients and will work on building their clinical histories. Jason has started to contribute as well.
--Marc
On Tue, Feb 17, 2015 at 9:47 AM, sglanger notifications@github.com wrote:
thanks
Are you getting together the histories of the other patient's?
From: Marc Kohli [mailto:notifications@github.com] Sent: Tuesday, February 17, 2015 8:33 AM To: shadowdoc/siim-dataset Cc: Langer, Steve G., Ph.D. Subject: Re: [siim-dataset] re-synched, updated json reports with "patient" name (#3)
Also - git mv is your friend when renaming.
Reply to this email directly or view it on GitHub< https://github.com/shadowdoc/siim-dataset/pull/3#issuecomment-74675912>.
— Reply to this email directly or view it on GitHub https://github.com/shadowdoc/siim-dataset/pull/3#issuecomment-74678364.
Marc; I think you should be able to use this