ImagoXV / NanoASV

NanoASV official repo
GNU General Public License v3.0
4 stars 0 forks source link

Replace NanoFilt and Porechop with Chopper #17

Closed ImagoXV closed 10 months ago

ImagoXV commented 10 months ago

conda install -c bioconda chopper

The problem is that I still need to install conda in my dockerfile

ImagoXV commented 10 months ago

It's done ! I didn't use conda in the end, just the archive. Works perfectly

frederic-mahe commented 9 months ago

In the dev branch, script.sh still calls chop_file() and porechop. Should it be removed then?

ImagoXV commented 9 months ago

Yes, NanoFilt was changed for chopper for efficiency reasons. Nanofilt was not maintained anymore and chopper is its rust version However, chopper does not implement the Porechop functionalities regarding adapter trimming