ImanKahlila / ProjectHunt

1 stars 7 forks source link

Create and implement CSS styles for login and signup page #41

Closed andrewquach-dev closed 1 year ago

andrewquach-dev commented 1 year ago

Checklist:

Kanchan253 commented 1 year ago

Hi @andrewquach-dev , I would like to work on this. Kindly assign this to me. And also can I know what you have in mind for the signup and login page design

andrewquach-dev commented 1 year ago

Hi @andrewquach-dev , I would like to work on this. Kindly assign this to me. And also can I know what you have in mind for the signup and login page design

I think you should design something similar to what @ImanKahlila designed (I linked the figma above). Once you've designed it, you can get feedback, and we can collaborate here. Finally, you can convert the design to CSS.

Kanchan253 commented 1 year ago

Hi @andrewquach-dev I have requested for the permission to view the figma file, please allow me the access so I can see it. Thank you.

ThomasCarney315 commented 1 year ago

@ImanKahlila is the owner of that Figma file. They can approve your request.

Kanchan253 commented 1 year ago

Hi @ImanKahlila I have sent a request for viewing the figma linked above , can you please grant me access so I can start on this.

ImanKahlila commented 1 year ago

@Kanchan253 I approved your viewing on Figma. Also you can check out everything as far as frontend design for this project in the Discussions.

Cheesely commented 1 year ago

Hey @Kanchan253 it might also be a good idea to ensure you collaborate with @IntelliJinceTech considering he is working on the sign in with discord and/or github ticket. I'm not 💯 sure that collaboration is necessary but it seems like there might be enough crossover to at least check in with each other considering both of these issues are being dealt with on totally different branches.

Kanchan253 commented 1 year ago

Hey @Cheesely I will discuss with @IntelliJinceTech once my styling is complete.

IreneLinWasHere commented 1 year ago

Question: for the alternative sign in methods (via GitHub and Discord), is it better to use pictures for the logos or icons from Font Awesome?

ImanKahlila commented 1 year ago

@IreneLinWasHere I would prefer the logos/pictures, but it’ll probably be a copyright issue. So I’d say use icons from Font Awesome. I’m sure it’s free icons for GitHub and Discord though.

On Tuesday, July 25, 2023, Irene Lin @.***> wrote:

Question: for the alternative sign in methods (via GitHub and Discord), is it better to use pictures for the logos or icons from Font Awesome?

— Reply to this email directly, view it on GitHub https://github.com/ImanKahlila/ProjectHunt/issues/41#issuecomment-1650421666, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2HXAYD4Z3EDBPHN2SUXKC3XSAN3HANCNFSM6AAAAAAYMYQ5HU . You are receiving this because you were mentioned.Message ID: @.***>

ThomasCarney315 commented 1 year ago

Question: for the alternative sign in methods (via GitHub and Discord), is it better to use pictures for the logos or icons from Font Awesome?

I think its preference and style more than anything. I like Working with icons and .svg images; they are simple and clean looking

IreneLinWasHere commented 1 year ago

I'm done styling the page, there is a weird issue with an extra login and sign up link. I'm not sure what is causing this. Could someone please help? (in branch 41-create-and-implement-css-styles-for-login-and-signup-page-reset)

extra login and sign up
andrewquach-dev commented 1 year ago

I think the issue is that the comments are being misinterpreted as EJS so deleting the comment stuff should fix it. image

Also, why is there a second branch called reset?

IreneLinWasHere commented 1 year ago

Thanks, that did the trick!

Re: 2nd branch, I couldn't resolve the issues I was having with Git on Friday, so I decided to abandon ship, make a new clone, and copy my files over. The 2nd branch was just in case I messed that up somehow.