Imanity-Software / ImanitySpigot3-git

Thee Issue Tracker for ImanitySpigot3
2 stars 0 forks source link

Improve enchanting table's enchant item speed #166

Open 0xbasel opened 1 year ago

0xbasel commented 1 year ago

Expected behavior

Everything is mentioned in "Observed/Actual behavior" section.

Observed/Actual behavior

That's all, if these bugs has been fixed it will be really huge for ImanitySpigot3 and as well as for PVP servers owners.

Steps/models to reproduce

It's all shown in the example videos above.

Plugin list

These issues/bugs can be occur in clean configs (fresh setup) of ImanitySpigot3 as well as 0 plugins.

ImanitySpigot3 version

2022.11.1 LTS BUILD 3

Agreements

Other

No response

xpghard commented 1 year ago

@q-ruler First issue is caused pings and lost packet to server. When i tested this on local it's working fine. With second issue i can agree. Enchant time is really slow. We need to fix it. With Third issue i see this is cause your server internet because we can see ghost lava block on video was caused by your client. To repair first and Third issue I propose you to change game hosting

0xbasel commented 1 year ago

@xpghard You can't confirm the issues while you are using localhost, try them with ~100ms-140ms so you can be fair, you will find that the issues is going around, also my host is perfect I'm using OVH game plan (dedicated server).

I won't post issues without testing them in all possible ways:

First issue, I'm pretty sure it's from ImanitySpigot3 (it's rarely/impossible to happen if your ping is low or using localhost) but if your ping higher than 90ms/100ms you will notice it clearly. You may think that since your ping is high, this is common sense to have this issue, but no just try another spigot fork or just PaperSpigot you won't notice the issue even if your ping is high/unplayable. Third issue, it's a client-side bug but it is possible to fix/prevent the bug from happening server-sided. (minemen server already did that).

xpghard commented 1 year ago

In any game, 100ms + is an unplayable value. If you're using ovh it's probably in the wrong location because that's how much ping I get when connecting to another continent. When I connect to the same ping doesn't go above 50ms. If everything is working on another forum at that ping are you able to record it? And as for ghost blocks, I know the story of the blazingpack client which is a sizable package in pols. To secure this on the server side is really difficult and few have that is why this client has ghost blocking, but I also think other clients have this option too. And when the ping increases it is normal that you have packet loss.

LeeGodSRC commented 1 year ago

For second issue, after some testing the enchanting speed is the same as TacoSpigot 1.8, we will consider it as a feature request rather than a bug.