closed file in upload_from_path

Imgur / imgurpython

Official Imgur python client library (deprecated)

MIT License

546 stars 116 forks source link

Closed ghost closed 8 years ago

ghost commented 8 years ago

The file no longer remains open after calling upload_from_path(). This would previously throw warnings. This fixes issues #45 and #52.

thrasr commented 8 years ago

Came here to report (and possibly fix) the same problem. Glad to see there is a PR open.

@Jasdev - Can we get a response for this PR? Would be very nice to have this warning removed.

jasdev commented 8 years ago

@thrasr Hey! I don't actually work at Imgur anymore, so I can't merge this :/ Maybe @jacobgreenleaf can help?

jacobgreenleaf commented 8 years ago

I will upload this to PIP later. Thanks @r-hughes

thrasr commented 8 years ago

:+1:

Thanks guys =D

ghost commented 8 years ago

No problem. I'll send you the bill.

OrganicIrradiation commented 8 years ago

I'm still getting the ResourceWarning with the PyPI version (1.1.6, uploaded 2015-04-23). @jacobgreenleaf could you upload the fixed version?