Send notifications with gcm

Imgur / incus

incus is a middleware for distributing messages via websockets, long polling, and push notifications

MIT License

361 stars 37 forks source link

Send notifications with gcm #70

Open AdriVanHoudt opened 9 years ago

AdriVanHoudt commented 9 years ago

See https://github.com/alexjlockwood/gcm/issues/9 I will do a PR to both the gcm module and Incus to allow this option

alexjlockwood commented 9 years ago

Hey guys,

Apparently a new Notification field was added for GCM messages. As mentioned above, I've gotten a request to update my GCM library with the new field: https://github.com/alexjlockwood/gcm/issues/9

Just wanted to check in with you guys before I make any changes. I've never made a publicly-visible change to the library's API before and want to make sure adding the new field won't accidentally break you guys (or anyone else).

Alex

AdriVanHoudt commented 9 years ago

I believe the tests are failing just because of that, does Go have a versioning system? You can release a major/breaking version (see semver) and people will need to activly update then

AdriVanHoudt commented 9 years ago

@alexjlockwood I updated the PR a bit can you have a look?