search

Imgur / incus

incus is a middleware for distributing messages via websockets, long polling, and push notifications
MIT License
361 stars 37 forks source link

allow notifications on gcm fixes #70 #71

Closed AdriVanHoudt closed 7 years ago

AdriVanHoudt commented 9 years ago

fixes #70

This can only be merged after https://github.com/alexjlockwood/gcm/pull/10 I will keep this up to date if the gcm PR changes

As stated in the other PR, not familiar with Go so if this needs any changed let me know.

AdriVanHoudt commented 9 years ago

I am assuming it error because atm gcm only takes 2 arguments

AdriVanHoudt commented 8 years ago

Would this be accepted with the change on the gcm library?

jacobgreenleaf commented 8 years ago

It looks like you have a syntax error.

A best approach would be to let us fork your gcm library and depend on that until gcm merges your branch.

I will get to this this week. Thanks!

AdriVanHoudt commented 8 years ago

Yeah I am used to Javascript where function params are optional so I implemented it that way so it might not break but that turned out to not be the case :D the author of the lib did let know to work on it but no progress yet. If you would like some changes to the interface or something now is the time ;)

AdriVanHoudt commented 8 years ago

So what is the progress on this? There was 1 more request on the PR to allow a ios specific key but I will add it the moment I know you will be using the fork I made.