search

Imgur / incus

incus is a middleware for distributing messages via websockets, long polling, and push notifications
MIT License
361 stars 37 forks source link

Changed LPOP to BLPOP in file redis_store.go #73

Closed samuelebistoletti closed 8 years ago

samuelebistoletti commented 8 years ago

New pull request with default BLPOP interval set at 0.

jacobgreenleaf commented 8 years ago

Hey it looks like the return values of BLPOP and LPOP are different. Specifically, LPOP always returns a bulk string or nil, and BLPOP x returns an array of length two of bulk strings. That makes the type cast to redis.Bytes(...) incorrect. I am reverting until this can be fixed to be an if statement that checks for nil and a coercion to []interface{} (concretely, [][]byte)