ImisDevelopers / 1_011_a_infektionsfall_uebermittellung

This repository is deprecated and has not been maintained for months!
https://imis-prototyp.de/
MIT License
22 stars 6 forks source link

Next dev #481

Closed JonasCir closed 4 years ago

JonasCir commented 4 years ago

@jabrandes @MichaelSp

This is the layout for the next dev branch. The server code is removed, the PoC for SORMAS is included.

JonasCir commented 4 years ago

@jabrandes good point, I think I created a tag. but I'm not familiar how GitHub handles them. Please feel free to create a tag or branch head, I'm not familiar with the latter one.

jabrandes commented 4 years ago

@JonasCir, I am not that familiar with tags, but it I know that it's quite easy to create a new branch. You could use

git branch <brachname>

to create a new branch and stay on the current, or use

git checkout -b <branchname>

to create a new branch and check it out at once. The current HEAD commit will be head of the newly created branch.

Edit: I could not find a tag in the Github repository. Could be that you need to push such tags like you would do with commits.

MichaelSp commented 4 years ago

I'd opt for removing server and gradle and moving client to root-dir. Why?

  1. If anyone is interested in the history: We are using git. It's there.
  2. New developers don't know about our past and expect a client frontend only repo, where the package.json is in the root. So I'd even drop gradle.
  3. Most CI-tasks are easier if you are not using a custom folder layout.
JonasCir commented 4 years ago

@jabrandes Ok I didn't understand, that you meant a new branch :smile: @MichaelSp Good points, gradle is gone and client is now in the root folder

github-actions[bot] commented 4 years ago

:arrow_right: Live preview at url: https://imis-pr-481-lfq7hnbpwq-ew.a.run.app :up: :warning: First access might be very slow, database is shared. :eyes:

MichaelSp commented 4 years ago

tag created: before-move-to-sormas