search

Immediate-Mode-UI / Nuklear

A single-header ANSI C immediate mode cross-platform GUI library
https://immediate-mode-ui.github.io/Nuklear/doc/index.html
Other
9.06k stars 542 forks source link

DONE: successfull attempt to enable and test vertical scrollbar in no… #530

Closed bart-at-qqdatafruits closed 1 year ago

bart-at-qqdatafruits commented 1 year ago

successful attempt to enable and test vertical scrollbar in node-editor demo, tested on allergo5 and sdl2 only contribution respects and maintains same license as project

dumblob commented 1 year ago

Hi @bart-at-qqdatafruits , sorry for the late reply. Our upstream is a bit slow. I have skimmed all the changes and I like them. It is only one commit but I think there is no need for nit picking. Except for version bump which is required.

I see you closed this PR - are you underway of some additional changes? If not, could you please bump version (take a look at how we review PRs) and reopen this PR?

Having both horizontal & vertical scrolling is a nice and useful feature. I remember there were some issues with scrolling in general, so we need to test this really thoroughly. And that will take some time (probably months), so do not feel unwelcome but rather the opposite - people will appreciate a new well-tested wished feature!