search

Immediate-Mode-UI / Nuklear

A single-header ANSI C immediate mode cross-platform GUI library
https://immediate-mode-ui.github.io/Nuklear/doc/index.html
Other
9.06k stars 542 forks source link

fix variable name in docs #545

Closed vabenil closed 1 year ago

vabenil commented 1 year ago

In the docs the variable size is declared but then ratio is used instead. This fixes that.

dumblob commented 1 year ago

Good catch!

Could you please align the PR with our review guidelines (https://github.com/Immediate-Mode-UI/Nuklear#reviewers-guide ) before we merge it?

Thanks!

vabenil commented 1 year ago

Good catch!

Could you please align the PR with our review guidelines (https://github.com/Immediate-Mode-UI/Nuklear#reviewers-guide ) before we merge it?

Thanks!

I read the reviewers guidelines but I'm not sure what to change. Should I just add my change to the Changelog?

dumblob commented 1 year ago

I read the reviewers guidelines but I'm not sure what to change. Should I just add my change to the Changelog?

No version bump needed. But we need the source files to be edited (nuklear.h is then generated/amalgamated from those :wink:).

Thanks!

vabenil commented 1 year ago

Got it. I made the same change in src/nuklear.h