Immediate-Mode-UI / Nuklear

A single-header ANSI C immediate mode cross-platform GUI library
https://immediate-mode-ui.github.io/Nuklear/doc/index.html
8.89k stars 533 forks source link

Add a style option to disable point markers on charts #602

Closed brianwatling closed 3 months ago

brianwatling commented 6 months ago

With point markers enabled (default): with_markers With point markers disabled: without_markers

Fixes #594

dumblob commented 5 months ago

Looks good to me in general. My personal preference would be to use a non-negated form (nk_bool show_markers; instead of nk_bool hide_markers;) but I would be fine merging if others will not agree :wink:.

RobLoach commented 5 months ago

That's a good point. Would it be possible to default nk_bool show_markers to nk_true when initializing the struct?

brianwatling commented 4 months ago

That's a good point. Would it be possible to default nk_bool show_markers to nk_true when initializing the struct?

Done - renamed to show_markers and defaults to nk_true to preserve existing default behaviour (and tested that)