search

ImmunHelden / ImmunHelden.de

Project and team formed in the #WirVsVirus Hackathon of the German Federal Government
http://immunhelden.de
MIT License
4 stars 1 forks source link

As a partner I want to use rich text for descriptions #161

Closed weliveindetail closed 4 years ago

weliveindetail commented 4 years ago

Next step for tickets #90 and #148: Allow partners to enter descriptions in rich text themselves.

Storing it as HTML in the database is the simplest solution, seeing that we want to query and display it the map directly. Currently, the conversion to HTML happens on the client side, which is a potential exploit: harmful users could instrument the JS and inject scripts into it that will run in other user's maps. We should deal with it at some point, e.g. do the conversion on the server side, but it's not very urgent IMHO.

Note: While we didn't finish reviewing https://github.com/ImmunHelden/ImmunHelden.de/pull/155 I pushed my latest snapshot to the preliminary edit-page branch in the base repo. Once we merge it, I will rebase on the new develop.

weliveindetail commented 4 years ago

looks good so far.

Cool, I am going to merge it.

Those it include all changes of #155 already

That's what my note in the description was about. Now that #155 is done, I changed the merge base to the new develop. Once the first has been built, deployed and tested, I will go merge this one.