ImmuneDynamics / Spectre

A computational toolkit in R for the integration, exploration, and analysis of high-dimensional single-cell cytometry and imaging data.
https://immunedynamics.github.io/spectre/
MIT License
56 stars 21 forks source link

Bug with nCells in prepareFlowSOM wrapper within Spectre general discovery workflow #171

Closed dgrfs closed 1 year ago

dgrfs commented 1 year ago

Issues with data being handed over to prepareFlowSOM. I understand that nCells has been given NULL argument, as subsampling should be done beforehand if following the Spectre workflow. However, in this case, nCells=NULL causes removal of all observations. Therefore, the whole prep.cytonorm wrapper breaks and with an error along the lines of "argument is of length zero". I've suggested creating an nCells argument in the prep.cytonorm function - though there may be a more efficient or cleaner way to make this work while still making sense within the Spectre workflow.