search

ImmutableOctet / sonicgba

A cross-platform port of Sonic Advance
https://www.reddit.com/r/sonicgba
Other
16 stars 2 forks source link

Colors are not accurately represented. #8

Closed ImmutableOctet closed 8 years ago

ImmutableOctet commented 8 years ago

Currently, manual assignment of colors is forbidden, representing certain effects incorrectly as a result.

This is especially noticeable when loading a level, where a tip will be presented using a drop-shadow. These drop-shadows are effects based on manual color selection (Black).

The main reason colors are not preserved currently is due to the lack of appropriate parsing/decoding, and context restoration.

This issue should be resolved pretty easily, it just hasn't been a priority.

ImmutableOctet commented 8 years ago

This has been largely fixed since commit fbac31e8287a6e3d72c6eca9565d230d2b8365e3 or so.

The occasional "color bleed" happens with bad collision-rectangle rendering, but nothing major. Color formatting is also consistent with the original version now.

In addition, software-based fading has been removed, and replaced with correctly rendered 'fade-rects' using the existing color system. This was fixed right around commit 1b2125e8b7d9a855a6772a822c1a2201a50f5007.